• execjosh's avatar
    Also stop at root when extracting CSS color · c8c67de8
    execjosh authored
    This change adds an additional check for whether the parent element
    is `null` or `undefined` in `$.color.extract`.  This can happen when
    working with elements that have not yet been added to the DOM under
    `<body>`.
    
    Consider the following example pie chart.
    
        var elm = $("<div />")
          .css({
            width: "240px"
          , height: "320px"
          })
        var data = [
          {label: "One", data: "33"}
        , {label: "Two", data: "33"}
        , {label: "Three", data: "33"}
        ]
        var opts = {
          legend: {
            show: true
          }
        , series: {
            pie: {
              show: true
            }
          }
        }
        $.plot(elm, data, opts)
        elm.appendTo($("body"))
    
    When flot inserts each legend row, it tries to use the same color as
    the corresponding graph part, unless it was explicitly specified in
    the options.  However, in this example, `$.color.extract` runs into
    an unexpected `null` reference because `<body>` is not an ancestor
    of `elm`.  Specifically, a `TypeError: Cannot read property
    'nodeName' of undefined` would be thrown.
    c8c67de8
Name
Last commit
Last update
examples Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
API.md Loading commit data...
CONTRIBUTING.md Loading commit data...
FAQ.md Loading commit data...
LICENSE.txt Loading commit data...
Makefile Loading commit data...
NEWS.md Loading commit data...
PLUGINS.md Loading commit data...
README.md Loading commit data...
component.json Loading commit data...
excanvas.js Loading commit data...
excanvas.min.js Loading commit data...
flot.jquery.json Loading commit data...
jquery.colorhelpers.js Loading commit data...
jquery.flot.canvas.js Loading commit data...
jquery.flot.categories.js Loading commit data...
jquery.flot.crosshair.js Loading commit data...
jquery.flot.errorbars.js Loading commit data...
jquery.flot.fillbetween.js Loading commit data...
jquery.flot.image.js Loading commit data...
jquery.flot.js Loading commit data...
jquery.flot.navigate.js Loading commit data...
jquery.flot.pie.js Loading commit data...
jquery.flot.resize.js Loading commit data...
jquery.flot.selection.js Loading commit data...
jquery.flot.stack.js Loading commit data...
jquery.flot.symbol.js Loading commit data...
jquery.flot.threshold.js Loading commit data...
jquery.flot.time.js Loading commit data...
jquery.js Loading commit data...
package.json Loading commit data...