Commit c98c3108 authored by David Schnur's avatar David Schnur

Merge pull request #889 from dnschnur/code-fixes

Fixed global variables and missing seimcolons.
parents 359db6d2 8b996405
...@@ -84,11 +84,11 @@ The plugin also adds four public methods: ...@@ -84,11 +84,11 @@ The plugin also adds four public methods:
if (pos) if (pos)
plot.setCrosshair(pos); plot.setCrosshair(pos);
crosshair.locked = true; crosshair.locked = true;
} };
plot.unlockCrosshair = function unlockCrosshair() { plot.unlockCrosshair = function unlockCrosshair() {
crosshair.locked = false; crosshair.locked = false;
} };
function onMouseOut(e) { function onMouseOut(e) {
if (crosshair.locked) if (crosshair.locked)
......
This diff is collapsed.
...@@ -110,7 +110,7 @@ images (like Google Maps). ...@@ -110,7 +110,7 @@ images (like Google Maps).
$('<img />').load(handler).error(handler).attr('src', url); $('<img />').load(handler).error(handler).attr('src', url);
}); });
} };
function drawSeries(plot, ctx, series) { function drawSeries(plot, ctx, series) {
var plotOffset = plot.getPlotOffset(); var plotOffset = plot.getPlotOffset();
......
...@@ -2293,7 +2293,7 @@ ...@@ -2293,7 +2293,7 @@
for (var i = 0; i < entries.length; ++i) { for (var i = 0; i < entries.length; ++i) {
entry = entries[i]; var entry = entries[i];
if (i % options.legend.noColumns == 0) { if (i % options.legend.noColumns == 0) {
if (rowStarted) if (rowStarted)
...@@ -2584,7 +2584,7 @@ ...@@ -2584,7 +2584,7 @@
function drawPointHighlight(series, point) { function drawPointHighlight(series, point) {
var x = point[0], y = point[1], var x = point[0], y = point[1],
axisx = series.xaxis, axisy = series.yaxis; axisx = series.xaxis, axisy = series.yaxis,
highlightColor = (typeof series.highlightColor === "string") ? series.highlightColor : $.color.parse(series.color).scale('a', 0.5).toString(); highlightColor = (typeof series.highlightColor === "string") ? series.highlightColor : $.color.parse(series.color).scale('a', 0.5).toString();
if (x < axisx.min || x > axisx.max || y < axisy.min || y > axisy.max) if (x < axisx.min || x > axisx.max || y < axisy.min || y > axisy.max)
......
...@@ -200,11 +200,11 @@ Licensed under the MIT License ~ http://threedubmedia.googlecode.com/files/MIT-L ...@@ -200,11 +200,11 @@ Licensed under the MIT License ~ http://threedubmedia.googlecode.com/files/MIT-L
args = {}; args = {};
if (!args.amount) if (!args.amount)
args.amount = plot.getOptions().zoom.amount args.amount = plot.getOptions().zoom.amount;
args.amount = 1 / args.amount; args.amount = 1 / args.amount;
plot.zoom(args); plot.zoom(args);
} };
plot.zoom = function (args) { plot.zoom = function (args) {
if (!args) if (!args)
...@@ -274,7 +274,7 @@ Licensed under the MIT License ~ http://threedubmedia.googlecode.com/files/MIT-L ...@@ -274,7 +274,7 @@ Licensed under the MIT License ~ http://threedubmedia.googlecode.com/files/MIT-L
if (!args.preventEvent) if (!args.preventEvent)
plot.getPlaceholder().trigger("plotzoom", [ plot, args ]); plot.getPlaceholder().trigger("plotzoom", [ plot, args ]);
} };
plot.pan = function (args) { plot.pan = function (args) {
var delta = { var delta = {
...@@ -322,7 +322,7 @@ Licensed under the MIT License ~ http://threedubmedia.googlecode.com/files/MIT-L ...@@ -322,7 +322,7 @@ Licensed under the MIT License ~ http://threedubmedia.googlecode.com/files/MIT-L
if (!args.preventEvent) if (!args.preventEvent)
plot.getPlaceholder().trigger("plotpan", [ plot ]); plot.getPlaceholder().trigger("plotpan", [ plot ]);
} };
function shutdown(plot, eventHolder) { function shutdown(plot, eventHolder) {
eventHolder.unbind(plot.getOptions().zoom.trigger, onZoomClick); eventHolder.unbind(plot.getOptions().zoom.trigger, onZoomClick);
......
...@@ -65,20 +65,21 @@ More detail and specific examples can be found in the included HTML file. ...@@ -65,20 +65,21 @@ More detail and specific examples can be found in the included HTML file.
function init(plot) { function init(plot) {
var canvas = null; var canvas = null,
var canvasWidth = 0; canvasWidth = 0,
var canvasHeight = 0; canvasHeight = 0,
var target = null; target = null,
var maxRadius = null; maxRadius = null,
var centerLeft = null; centerLeft = null,
var centerTop = null; centerTop = null,
var total = 0; total = 0,
var redraw = true; redraw = true,
var redrawAttempts = 10; redrawAttempts = 10,
var shrink = 0.95; shrink = 0.95,
var legendWidth = 0; legendWidth = 0,
var processed = false; processed = false,
var raw = false; raw = false,
ctx = null;
// interactive variables // interactive variables
...@@ -528,7 +529,7 @@ More detail and specific examples can be found in the included HTML file. ...@@ -528,7 +529,7 @@ More detail and specific examples can be found in the included HTML file.
// subtract the center // subtract the center
layer.save(); layer.save();
innerRadius = options.series.pie.innerRadius > 1 ? options.series.pie.innerRadius : maxRadius * options.series.pie.innerRadius; var innerRadius = options.series.pie.innerRadius > 1 ? options.series.pie.innerRadius : maxRadius * options.series.pie.innerRadius;
layer.globalCompositeOperation = "destination-out"; // this does not work with excanvas, but it will fall back to using the stroke color layer.globalCompositeOperation = "destination-out"; // this does not work with excanvas, but it will fall back to using the stroke color
layer.beginPath(); layer.beginPath();
layer.fillStyle = options.series.pie.stroke.color; layer.fillStyle = options.series.pie.stroke.color;
...@@ -563,9 +564,10 @@ More detail and specific examples can be found in the included HTML file. ...@@ -563,9 +564,10 @@ More detail and specific examples can be found in the included HTML file.
function findNearbySlice(mouseX, mouseY) { function findNearbySlice(mouseX, mouseY) {
var slices = plot.getData(); var slices = plot.getData(),
var options = plot.getOptions(); options = plot.getOptions(),
var radius = options.series.pie.radius > 1 ? options.series.pie.radius : maxRadius * options.series.pie.radius; radius = options.series.pie.radius > 1 ? options.series.pie.radius : maxRadius * options.series.pie.radius,
x, y;
for (var i = 0; i < slices.length; ++i) { for (var i = 0; i < slices.length; ++i) {
...@@ -597,18 +599,18 @@ More detail and specific examples can be found in the included HTML file. ...@@ -597,18 +599,18 @@ More detail and specific examples can be found in the included HTML file.
// excanvas for IE doesn;t support isPointInPath, this is a workaround. // excanvas for IE doesn;t support isPointInPath, this is a workaround.
p1X = radius * Math.cos(s.startAngle); var p1X = radius * Math.cos(s.startAngle),
p1Y = radius * Math.sin(s.startAngle); p1Y = radius * Math.sin(s.startAngle),
p2X = radius * Math.cos(s.startAngle + s.angle / 4); p2X = radius * Math.cos(s.startAngle + s.angle / 4),
p2Y = radius * Math.sin(s.startAngle + s.angle / 4); p2Y = radius * Math.sin(s.startAngle + s.angle / 4),
p3X = radius * Math.cos(s.startAngle + s.angle / 2); p3X = radius * Math.cos(s.startAngle + s.angle / 2),
p3Y = radius * Math.sin(s.startAngle + s.angle / 2); p3Y = radius * Math.sin(s.startAngle + s.angle / 2),
p4X = radius * Math.cos(s.startAngle + s.angle / 1.5); p4X = radius * Math.cos(s.startAngle + s.angle / 1.5),
p4Y = radius * Math.sin(s.startAngle + s.angle / 1.5); p4Y = radius * Math.sin(s.startAngle + s.angle / 1.5),
p5X = radius * Math.cos(s.startAngle + s.angle); p5X = radius * Math.cos(s.startAngle + s.angle),
p5Y = radius * Math.sin(s.startAngle + s.angle); p5Y = radius * Math.sin(s.startAngle + s.angle),
arrPoly = [[0, 0], [p1X, p1Y], [p2X, p2Y], [p3X, p3Y], [p4X, p4Y], [p5X, p5Y]]; arrPoly = [[0, 0], [p1X, p1Y], [p2X, p2Y], [p3X, p3Y], [p4X, p4Y], [p5X, p5Y]],
arrPoint = [x, y]; arrPoint = [x, y];
// TODO: perhaps do some mathmatical trickery here with the Y-coordinate to compensate for pie tilt? // TODO: perhaps do some mathmatical trickery here with the Y-coordinate to compensate for pie tilt?
...@@ -672,9 +674,9 @@ More detail and specific examples can be found in the included HTML file. ...@@ -672,9 +674,9 @@ More detail and specific examples can be found in the included HTML file.
} }
function highlight(s, auto) { function highlight(s, auto) {
if (typeof s == "number") { //if (typeof s == "number") {
s = series[s]; // s = series[s];
} //}
var i = indexOfHighlight(s); var i = indexOfHighlight(s);
...@@ -692,9 +694,9 @@ More detail and specific examples can be found in the included HTML file. ...@@ -692,9 +694,9 @@ More detail and specific examples can be found in the included HTML file.
plot.triggerRedrawOverlay(); plot.triggerRedrawOverlay();
} }
if (typeof s == "number") { //if (typeof s == "number") {
s = series[s]; // s = series[s];
} //}
var i = indexOfHighlight(s); var i = indexOfHighlight(s);
...@@ -723,7 +725,7 @@ More detail and specific examples can be found in the included HTML file. ...@@ -723,7 +725,7 @@ More detail and specific examples can be found in the included HTML file.
octx.translate(centerLeft, centerTop); octx.translate(centerLeft, centerTop);
octx.scale(1, options.series.pie.tilt); octx.scale(1, options.series.pie.tilt);
for (i = 0; i < highlights.length; ++i) { for (var i = 0; i < highlights.length; ++i) {
drawHighlight(highlights[i].series); drawHighlight(highlights[i].series);
} }
......
...@@ -71,7 +71,7 @@ adjusted (e.g for bar charts or filled areas). ...@@ -71,7 +71,7 @@ adjusted (e.g for bar charts or filled areas).
fromgap = true, fromgap = true,
keyOffset = horizontal ? 1 : 0, keyOffset = horizontal ? 1 : 0,
accumulateOffset = horizontal ? 0 : 1, accumulateOffset = horizontal ? 0 : 1,
i = 0, j = 0, l; i = 0, j = 0, l, m;
while (true) { while (true) {
if (i >= points.length) if (i >= points.length)
......
...@@ -51,7 +51,7 @@ choice: ...@@ -51,7 +51,7 @@ choice:
ctx.moveTo(x - size, y + size); ctx.moveTo(x - size, y + size);
ctx.lineTo(x + size, y - size); ctx.lineTo(x + size, y - size);
} }
} };
var s = series.points.symbol; var s = series.points.symbol;
if (handlers[s]) if (handlers[s])
......
...@@ -61,7 +61,7 @@ events. ...@@ -61,7 +61,7 @@ events.
var m; var m;
for (i = 0; i < origpoints.length; i += ps) { for (i = 0; i < origpoints.length; i += ps) {
x = origpoints[i] x = origpoints[i];
y = origpoints[i + 1]; y = origpoints[i + 1];
prevp = p; prevp = p;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment